Fixing problems with pasting from clipboard after tabs reorder #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, 👍 for me |
|
Also fixes #473. |
|
good catch. All this code is buggy, tab management is buggy, this prevents to easily do something like split terminal or save session... If I had time I would rewrite all of this. Thanks for the PL and time you spend on debuging this issue! |
gsemet
added a commit
that referenced
this pull request
May 2, 2015
Fixing problems with pasting from clipboard after tabs reorder
|
This bug as well as #473 are still present when not swapping tabs next to each other.
This is because you do not only have to swap the terms by |
gsemet
added a commit
that referenced
this pull request
Jan 30, 2017
Fixing problems with pasting from clipboard after tabs reorder
gsemet
pushed a commit
that referenced
this pull request
Jan 30, 2017
gsemet
added a commit
that referenced
this pull request
Jan 30, 2017
Fixing problems with pasting from clipboard after tabs reorder
gsemet
pushed a commit
that referenced
this pull request
Jan 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Guake with 2 tabs. Paste some text in theese terminals, everything is ok.
Swap them. Now when you try to paste text in the first tab, it will be pasted in the second tab.
This is because we don't change order of GuakeNotebook's term_list when the order of GuakeNotebook's pages changes. When we paste something, accel_paste_clipboard() method calls (guake_app.py), it detects terminal in GuakeNotebook by the index of the current page.
I redefined reorder_child() method of GuakeNotebook. So when you reorder pages in GuakeNotebook, terminals will reorder automatically.